Refactor some tests to use ArrayValidationNode #186
Conversation
arcondello
changed the title
| @@ -120,8 +121,6 @@ TEST_CASE("AdvancedIndexingNode") { | |||
| CHECK(B_ptr->size(state) == s_ptr->size(state)); | |||
|
|
|||
| CHECK(std::ranges::equal(B_ptr->view(state), std::vector{4})); | |||
|
|
|||
| verify_array_diff({}, {4}, B_ptr->diff(state)); | |||
There was a problem hiding this comment.
Don't we need to call propagate on the ArrayValidationNode to ensure the diff is valid? Maybe we can switch a lot of these tests to using graph->propagate() so we don't have to propagate all the nodes individually...
There was a problem hiding this comment.
Oh! Good catch. Will fix everywhere.
There was a problem hiding this comment.
Ok, should be fixed. Also made the tests a bit more future proof by just propagating/commiting/reverting all descendants.
arcondello
force-pushed
the
feature/use-ArrayValidationNode-more
branch
from
13534ef to
3b310b8
Compare
| @@ -463,6 +450,8 @@ TEST_CASE("SetNode") { | |||
|
|
|||
| auto ptr = graph.emplace_node<SetNode>(num_elements); | |||
|
|
|||
| graph.emplace_node<ArrayValidationNode>(ptr); | |||
There was a problem hiding this comment.
I think you're still missing propagate and revert for this one
There was a problem hiding this comment.
Good catch. Ok, this time I think I got them all.
There was a problem hiding this comment.
ah, still an error. One sec.
There was a problem hiding this comment.
ok, fixed. This time for real.
arcondello
force-pushed
the
feature/use-ArrayValidationNode-more
branch
2 times, most recently
from
521da7b to
fa7bd8f
Compare
Replace uses of
verify_array_diffwithArrayValidationNode.